Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make syslog facility code configurable #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

claudijd
Copy link

@claudijd claudijd commented Aug 30, 2018

An untested attempt at fixing syslog facility parameter

Closes #103

@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

Merging #104 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   67.98%   67.94%   -0.04%     
==========================================
  Files          47       47              
  Lines        1899     1900       +1     
==========================================
  Hits         1291     1291              
- Misses        608      609       +1
Impacted Files Coverage Δ
integrations/syslog/integration.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f251328...31125f1. Read the comment docs.

@omercnet
Copy link
Contributor

Looks good but please test and report back as we dont have automated testing for integrations yet

@dekelb
Copy link
Contributor

dekelb commented Nov 6, 2018

@claudijd did you manage to test this code? It will be great to approve this PR, but we want to make sure everything works before we push things to master.

@claudijd
Copy link
Author

claudijd commented Nov 6, 2018

@dekelb I wasn't able to test, and I no longer needing this patch upstream. That said, I think there is value leaving it open as a consideration for improvement, should someone have the ability to confirm or ammend it's viability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to change syslog facility to an arbitrary value
3 participants