Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support content for the ftp plugin #109

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dekelb
Copy link
Contributor

@dekelb dekelb commented Dec 6, 2018

No description provided.

@ghost ghost assigned dekelb Dec 6, 2018
@ghost ghost added the in progress label Dec 6, 2018
lorg
lorg previously approved these changes Dec 6, 2018
Copy link
Contributor

@omercnet omercnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please additional help text explaining the options for this parameter

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #109 into master will decrease coverage by 0.03%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   67.29%   67.26%   -0.04%     
==========================================
  Files          51       51              
  Lines        2162     2175      +13     
==========================================
+ Hits         1455     1463       +8     
- Misses        707      712       +5
Impacted Files Coverage Δ
services/ftp/ftp_service.py 79.52% <61.53%> (-2.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72dda8a...b139ed6. Read the comment docs.

@dekelb
Copy link
Contributor Author

dekelb commented Dec 9, 2018

@omercnet text changed, please check and approve

services/ftp/config.json Outdated Show resolved Hide resolved
omercnet and others added 2 commits December 9, 2018 17:27
pr

Co-Authored-By: dekelb <dekelb@users.noreply.github.com>
@ghost ghost assigned omercnet Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants