Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SerializableReactiveProperty not reactive to Untiy inspector changes? #133

Closed
pinkeyyy opened this issue Feb 24, 2024 · 1 comment · Fixed by #140
Closed

SerializableReactiveProperty not reactive to Untiy inspector changes? #133

pinkeyyy opened this issue Feb 24, 2024 · 1 comment · Fixed by #140

Comments

@pinkeyyy
Copy link

Firstly, great library, so thank you!

However, a small behavioural issue I've encountered which I would like to clarify is intended.

I figured with the introduction of SerializableReactiveProperty to expose ReactiveProperty to the Unity editor's inspector would also mean that susbcribers would be notified of changes to the property made in the inspector?

This doesn't seem to be the case from my experiments so far, so would like to clarify if this is in the intended behaviour. The docs aren't clear on this from what I've seen so far.

Thanks!

@neuecc
Copy link
Member

neuecc commented Feb 25, 2024

Previously, we handled it with a simple execution from OnAfterDeserialize , but we stopped because there were issues with that approach.
#94
I'll try implementing it by executing ForceNotify via reflection after changing the values in the editor inspector (UniRx was implemented this way).
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants