Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ObservableStateMachineTrigger to R3.Unity #103

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

TORISOUP
Copy link
Contributor

Added "ObservableStateMachineTrigger" that existed in UniRx.
The implementation is almost a copy of the UniRx side.

@TORISOUP
Copy link
Contributor Author

StateMachineBehaviour cannot emit OnCompleted because it cannot detect the end of the StateMachineBehaviour.
However, I am afraid that implementing IDisposable in StateMachineBehaviour may be inconvenient.

Is it unnecessary to implement termination?

@neuecc
Copy link
Member

neuecc commented Feb 15, 2024

It's a unique system in terms of how it's used, so I think it's fine as it is!

@neuecc neuecc merged commit 9fed1ef into Cysharp:main Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants