replaced todo with descriptive error (#858)

DA0-DA0 · Jul 22, 2024 · f0dceb1 · f0dceb1
1 parent aa0fa5f
commit f0dceb1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/contracts/distribution/dao-rewards-distributor/src/error.rs b/contracts/distribution/dao-rewards-distributor/src/error.rs
@@ -51,4 +51,7 @@ pub enum ContractError {
 
     #[error("There is no voting power registered, so no one will receive these funds")]
     NoVotingPowerNoRewards {},
+
+    #[error("Cannot update emission rate because this distribution has accumulated the maximum rewards. Start a new distribution with the new emission rate instead. (Overflow: {err})")]
+    DistributionHistoryTooLarge { err: String },
 }
diff --git a/contracts/distribution/dao-rewards-distributor/src/state.rs b/contracts/distribution/dao-rewards-distributor/src/state.rs
@@ -273,10 +273,12 @@ impl DistributionState {
         };
 
         // 2. add current epoch rewards earned to historical rewards
-        // TODO: what to do on overflow?
         self.historical_earned_puvp = self
             .historical_earned_puvp
-            .checked_add(self.active_epoch.total_earned_puvp)?;
+            .checked_add(self.active_epoch.total_earned_puvp)
+            .map_err(|err| ContractError::DistributionHistoryTooLarge {
+                err: err.to_string(),
+            })?;
 
         // 3. deduct the distributed rewards amount from total funded amount, as
         // those rewards are no longer distributed in the new epoch