Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump cosmwasm-std to 1.5.4 #824

Merged
merged 1 commit into from
May 22, 2024
Merged

bump cosmwasm-std to 1.5.4 #824

merged 1 commit into from
May 22, 2024

Conversation

bekauz
Copy link
Collaborator

@bekauz bekauz commented Apr 27, 2024

following the latest cw security advisory, we bump the version of cosmwasm-std from 1.5.0 to 1.5.4.

given that overflow-checks = true flag is enabled, we are only affected by:

  • Uint{64,128}::pow / Int{64,128}::pow
  • Int{64,128}::neg (the unary negation operator -). The only value that can overflow is Int{64,128}::MIN.

affected contracts (potentially):

  • cw20-stake-external-rewards
  • dao-voting-cw20-staked
  • dao-voting-cw721-staked
  • dao-voting-token-staked
  • dao-voting

JakeHartnell
JakeHartnell approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoahSaso NoahSaso merged commit 87485be into development May 22, 2024
6 of 7 checks passed
@NoahSaso NoahSaso deleted the benskey/cw-version-bump branch May 22, 2024 16:39
ismellike added a commit to Arena-DAO/dao-contracts that referenced this pull request Jul 19, 2024
@ismellike
Squashed commit of the following:
3a3da47 
commit 0c09c62
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Thu Jul 18 20:56:03 2024 -0500

    Revert integration_tests.yml

commit c46937a
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Wed Jul 17 13:18:11 2024 -0500

    Update basic.yml to cache only cargo deps

    Nightly toolchain is required for integration_tests

commit 7773cb0
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Wed Jul 17 12:45:09 2024 -0500

    Set integration_tests toolchain to latest stable

commit 74aea83
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Thu Jul 11 02:21:52 2024 -0500

    Cargo schema + fix orch wasm build and tests

commit e8081ac
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Thu Jul 11 00:40:32 2024 -0500

    Fix cargo stuff

commit d5a1850
Merge: 87925b2 5918cbe
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Wed Jul 10 23:48:52 2024 -0500

    Merge branch 'development' into feature/cw-orch-interface

commit 87925b2
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Wed Jul 10 23:47:50 2024 -0500

    Add cache to basic.yml

commit 2951f8c
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Wed Jul 10 23:47:40 2024 -0500

    Fix lints

    Also updates just lint to match basic.yml

commit 5918cbe
Author: noah <noahsaso@gmail.com>
Date:   Mon Jul 8 18:33:22 2024 -0400

    OmniFlix NFT (x/onft) staked voting module (DA0-DA0#838)

commit ac249f4
Author: noah <noahsaso@gmail.com>
Date:   Sat Jul 6 23:11:22 2024 -0400

    Improve pre-propose proposal creation permission granularity (and bump versions to v2.5.0) (DA0-DA0#843)

commit 8be18d1
Author: bekauz <bekauz@protonmail.com>
Date:   Mon Jun 17 18:05:24 2024 +0200

    staking rewards distribution followup (DA0-DA0#835)

    Co-authored-by: Noah Saso <noahsaso@gmail.com>
    Co-authored-by: Jake Hartnell <jake.hartnell@gmail.com>

commit bb8224e
Author: noah <noahsaso@gmail.com>
Date:   Thu Jun 6 00:32:12 2024 -0400

    moved .cargo/config to .cargo/config.toml (DA0-DA0#837)

commit 87485be
Author: bekauz <bekauz@protonmail.com>
Date:   Wed May 22 18:39:06 2024 +0200

    bump cw-std to 1.5.4 (DA0-DA0#824)

commit 8c945ac
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Fri May 17 09:09:32 2024 +0000

    Added other derives

commit f720001
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Fri May 17 09:06:45 2024 +0000

    Added derive fns

commit 003f87d
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Fri May 17 08:54:07 2024 +0000

    Fix tests

commit 88ec5ed
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Fri May 17 08:52:54 2024 +0000

    Added Queryfns on voting

commit 3440d34
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Fri May 17 08:06:38 2024 +0000

    Finalize test changes

commit 9492e37
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Fri May 17 07:40:35 2024 +0000

    More tests

commit 5883c87
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Thu May 16 17:24:41 2024 +0000

    Added tests with cw-orch

commit b01de1c
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Thu May 16 14:41:02 2024 +0000

    First test modifications

commit 3ab7017
Author: noah <noahsaso@gmail.com>
Date:   Mon Apr 1 20:04:11 2024 +0200

    Update versions to 2.4.2 (DA0-DA0#817)

commit caea80a
Author: noah <noahsaso@gmail.com>
Date:   Mon Apr 1 19:32:50 2024 +0200

    support kujira's /kujira.denom... tokenfactory fork (DA0-DA0#816)
ismellike added a commit to Arena-DAO/dao-contracts that referenced this pull request Jul 19, 2024
@ismellike
Squashed commit of the following:
15f299c 
commit aff2c4e
Author: Gabe <glopez11193@gmail.com>
Date:   Fri Jul 19 12:08:16 2024 -0500

    Revert basic.yml

    i think caching is causing issues with the cargo.lock

commit 6db4637
Author: Gabe <glopez11193@gmail.com>
Date:   Fri Jul 19 12:06:17 2024 -0500

    Lint + not(target_arch = "wasm32") in lib.rs

commit 18241d0
Merge: 761a780 87847fd
Author: Gabe <glopez11193@gmail.com>
Date:   Fri Jul 19 10:58:25 2024 -0500

    Merge branch 'pr/1' into feature/cw-orch-interface

commit 761a780
Author: Gabe <glopez11193@gmail.com>
Date:   Fri Jul 19 02:40:02 2024 -0500

    Update to cw-orch .24.1

commit 0c09c62
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Thu Jul 18 20:56:03 2024 -0500

    Revert integration_tests.yml

commit c46937a
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Wed Jul 17 13:18:11 2024 -0500

    Update basic.yml to cache only cargo deps

    Nightly toolchain is required for integration_tests

commit 7773cb0
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Wed Jul 17 12:45:09 2024 -0500

    Set integration_tests toolchain to latest stable

commit 87847fd
Author: hard-nett <hardnettt@proton.me>
Date:   Sat Jul 13 18:53:38 2024 +0000

    add cw-orch to external contract

commit 74aea83
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Thu Jul 11 02:21:52 2024 -0500

    Cargo schema + fix orch wasm build and tests

commit e8081ac
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Thu Jul 11 00:40:32 2024 -0500

    Fix cargo stuff

commit d5a1850
Merge: 87925b2 5918cbe
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Wed Jul 10 23:48:52 2024 -0500

    Merge branch 'development' into feature/cw-orch-interface

commit 87925b2
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Wed Jul 10 23:47:50 2024 -0500

    Add cache to basic.yml

commit 2951f8c
Author: Gabriel Lopez <glopez11193@gmail.com>
Date:   Wed Jul 10 23:47:40 2024 -0500

    Fix lints

    Also updates just lint to match basic.yml

commit 5918cbe
Author: noah <noahsaso@gmail.com>
Date:   Mon Jul 8 18:33:22 2024 -0400

    OmniFlix NFT (x/onft) staked voting module (DA0-DA0#838)

commit ac249f4
Author: noah <noahsaso@gmail.com>
Date:   Sat Jul 6 23:11:22 2024 -0400

    Improve pre-propose proposal creation permission granularity (and bump versions to v2.5.0) (DA0-DA0#843)

commit 8be18d1
Author: bekauz <bekauz@protonmail.com>
Date:   Mon Jun 17 18:05:24 2024 +0200

    staking rewards distribution followup (DA0-DA0#835)

    Co-authored-by: Noah Saso <noahsaso@gmail.com>
    Co-authored-by: Jake Hartnell <jake.hartnell@gmail.com>

commit bb8224e
Author: noah <noahsaso@gmail.com>
Date:   Thu Jun 6 00:32:12 2024 -0400

    moved .cargo/config to .cargo/config.toml (DA0-DA0#837)

commit 87485be
Author: bekauz <bekauz@protonmail.com>
Date:   Wed May 22 18:39:06 2024 +0200

    bump cw-std to 1.5.4 (DA0-DA0#824)

commit 8c945ac
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Fri May 17 09:09:32 2024 +0000

    Added other derives

commit f720001
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Fri May 17 09:06:45 2024 +0000

    Added derive fns

commit 003f87d
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Fri May 17 08:54:07 2024 +0000

    Fix tests

commit 88ec5ed
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Fri May 17 08:52:54 2024 +0000

    Added Queryfns on voting

commit 3440d34
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Fri May 17 08:06:38 2024 +0000

    Finalize test changes

commit 9492e37
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Fri May 17 07:40:35 2024 +0000

    More tests

commit 5883c87
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Thu May 16 17:24:41 2024 +0000

    Added tests with cw-orch

commit b01de1c
Author: Kayanski <kowalski.kowalskin@gmail.com>
Date:   Thu May 16 14:41:02 2024 +0000

    First test modifications

commit 3ab7017
Author: noah <noahsaso@gmail.com>
Date:   Mon Apr 1 20:04:11 2024 +0200

    Update versions to 2.4.2 (DA0-DA0#817)

commit caea80a
Author: noah <noahsaso@gmail.com>
Date:   Mon Apr 1 19:32:50 2024 +0200

    support kujira's /kujira.denom... tokenfactory fork (DA0-DA0#816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeHartnell JakeHartnell JakeHartnell approved these changes

@NoahSaso NoahSaso Awaiting requested review from NoahSaso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bekauz @JakeHartnell @NoahSaso