Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unwrap_or_default attr values #829

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Fix unwrap_or_default attr values #829

merged 3 commits into from
Aug 12, 2024

Conversation

ismellike
Copy link
Contributor

Closes #828

@JakeHartnell
Copy link
Member

Ah, really good catch. Just some linting errors, then LGTM.

JakeHartnell
JakeHartnell approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

NoahSaso
NoahSaso approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@NoahSaso NoahSaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🙏

@NoahSaso NoahSaso merged commit e521419 into DA0-DA0:development Aug 12, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeHartnell JakeHartnell JakeHartnell approved these changes

@NoahSaso NoahSaso NoahSaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response attributes with null/empty values
3 participants
@ismellike @JakeHartnell @NoahSaso