Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cw-orch #831

Closed
wants to merge 8 commits into from
Closed

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented May 16, 2024

This PR aims at adding cw-orch inside Dao-Dao.
Tasks to fill :

  • Add a cw-orch-interface package with all the contract interfaces.
  • Add the derive macros on all execute and query msgs
  • Write tests using cw-orch syntax
  • Osmosis Test Tube tests
  • Include artifacts in there (at least in crates.io release).

@Kayanski Kayanski marked this pull request as ready for review May 17, 2024 09:14
@ismellike
Copy link
Contributor

Minor request
It would be great to use the id = <default contract id> syntax for the contract interfaces.
https://orchestrator.abstract.money/contracts/interfaces.html#creating-an-interface

@Kayanski
Copy link
Contributor Author

Minor request It would be great to use the id = <default contract id> syntax for the contract interfaces. https://orchestrator.abstract.money/contracts/interfaces.html#creating-an-interface

yes god idea !
However, when doing so, you won't be able to use the 2 same contracts inside a project. You wouldn't be able to test or script simply with 2 daos for instance, is that acceptable ?

@ismellike
Copy link
Contributor

Minor request It would be great to use the id = <default contract id> syntax for the contract interfaces. https://orchestrator.abstract.money/contracts/interfaces.html#creating-an-interface

yes god idea ! However, when doing so, you won't be able to use the 2 same contracts inside a project. You wouldn't be able to test or script simply with 2 daos for instance, is that acceptable ?

Ah ok! I wasn't aware of that, so it's probably not great from an external perspective. Thanks, happy with this as is.

Copy link
Member

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I love cw-orchestrator. It's so nice.

This is a good start. Refactoring the rest of the tests could be done piecemeal. I do think tests are our biggest piece of tech debt as when we started we didn't have as good of tools or patterns as we now have today.

@JakeHartnell
Copy link
Member

Closing in favor of #876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants