Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitSong FanToken (x/fantoken) factory for token staking voting module #836

Closed
wants to merge 25 commits into from

Conversation

NoahSaso
Copy link
Member

@NoahSaso NoahSaso commented Jun 5, 2024

btsg-ft-factory

Serves as a factory that issues new
fantokens
on BitSong and returns their denom for use with the
dao-voting-token-staked voting module
contract.

Instantiation and execution are permissionless. All DAOs will use the same
factory and execute Issue to create new fantokens through TokenInfo::Factory
during voting module instantiation.

@NoahSaso NoahSaso force-pushed the noah/bitsong-fantoken branch 6 times, most recently from aec2030 to ac2aa4a Compare June 6, 2024 04:33
@NoahSaso NoahSaso force-pushed the noah/bitsong-fantoken branch 2 times, most recently from 64ab779 to a7ca6b1 Compare June 18, 2024 16:56
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 91.96035% with 73 lines in your changes missing coverage. Please review.

Project coverage is 96.43%. Comparing base (87485be) to head (6772523).
Report is 3 commits behind head on development.

Files Patch % Lines
contracts/external/btsg-ft-factory/src/bitsong.rs 30.30% 23 Missing ⚠️
...al/btsg-ft-factory/src/testing/bitsong_stargate.rs 88.51% 17 Missing ⚠️
contracts/external/btsg-ft-factory/src/shim.rs 0.00% 15 Missing ⚠️
contracts/external/btsg-ft-factory/src/contract.rs 96.62% 5 Missing ⚠️
...acts/external/btsg-ft-factory/src/testing/tests.rs 99.15% 4 Missing ⚠️
...tracts/external/btsg-ft-factory/src/testing/app.rs 80.00% 3 Missing ⚠️
...cts/voting/dao-voting-token-staked/src/contract.rs 80.00% 3 Missing ⚠️
contracts/external/btsg-ft-factory/src/msg.rs 66.66% 2 Missing ⚠️
contracts/external/btsg-ft-factory/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #836      +/-   ##
===============================================
+ Coverage        96.26%   96.43%   +0.17%     
===============================================
  Files              209      226      +17     
  Lines            53514    59468    +5954     
===============================================
+ Hits             51513    57346    +5833     
- Misses            2001     2122     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NoahSaso NoahSaso marked this pull request as ready for review June 18, 2024 17:58
@NoahSaso NoahSaso changed the title bitsong fantoken support BitSong FanToken (x/fantoken) factory creation support Jun 18, 2024
@NoahSaso NoahSaso changed the title BitSong FanToken (x/fantoken) factory creation support BitSong FanToken (x/fantoken) factory for token staking voting module Jun 18, 2024
@NoahSaso NoahSaso changed the base branch from development to noah/omniflix June 23, 2024 20:00
@NoahSaso NoahSaso changed the base branch from noah/omniflix to development July 7, 2024 03:23
@NoahSaso
Copy link
Member Author

NoahSaso commented Jul 8, 2024

Closing in favor of #845

@NoahSaso NoahSaso closed this Jul 8, 2024
@NoahSaso NoahSaso deleted the noah/bitsong-fantoken branch July 8, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants