[audit] 8. Suboptimal storage update

[NoahSaso]

From Oak:

In packages/dao-pre-propose-base/src/execute.rs:199, the execute_update_config function validates the submission_policy parameter in line 213 and updates it to the Config state.

However, this is inefficient because the Config state is retrieved in line 211 before validating the submission policy. If the submission policy does not pass the validation, the loaded storage value (indicated as the prev variable) remains unused.

This fix moves the validation to before the Config state storage read.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (75272b9) to head (b4ab941).

Additional details and impacted files

@@             Coverage Diff              @@
##           development     #867   +/-   ##
============================================
  Coverage        96.64%   96.65%           
============================================
  Files              240      240           
  Lines            65294    65297    +3     
============================================
+ Hits             63106    63110    +4     
+ Misses            2188     2187    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.