-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor DAO creation flows and load native/token factory metadata from chain #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
…posal deposit config.
…ort both cw20s and native/factory denoms.
Awesome! Related smart contract work: DA0-DA0/dao-contracts#664 |
NoahSaso
changed the title
Support token factory DAOs
Refactor DAO creation flows and load native/token factory metadata from chain
Jun 28, 2023
JakeHartnell
approved these changes
Jun 28, 2023
This was referenced Jun 28, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, each voting module adapter (membership, cw20, and NFT) is allowed to add exactly one DAO creation flow. This PR refactors the DAO creation system to separate adapters from creators, which prepares for the future support of token factory DAOs and allows more intricate DAO presets. For example, one could create a DAO preset for various types of businesses, each of which may use any of the available modules.
This PR also detects token factory denominations and loads their metadata from the chain, which is required to support chains that use token factory tokens and for the future support of token factory DAOs.