Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NFT collection tab performance #1296

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

NoahSaso
Copy link
Member

This paginates the NFT collection tab and lazy loads NFT card info so nothing loads until an NFT is showing. This significantly improves performance on DAO pages with lots of NFTs, such as Atlas DAO that has 2900 NFTs all loading at once.

@vercel
Copy link

vercel bot commented Jun 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dapp-juno ✅ Ready (Inspect) Visit Preview Jun 29, 2023 7:34pm
dapp-juno-testnet ✅ Ready (Inspect) Visit Preview Jun 29, 2023 7:34pm
dapp-osmosis ❌ Failed (Inspect) Jun 29, 2023 7:34pm
dapp-osmosis-testnet ❌ Failed (Inspect) Jun 29, 2023 7:34pm
sda-juno ✅ Ready (Inspect) Visit Preview Jun 29, 2023 7:34pm
sda-juno-testnet ✅ Ready (Inspect) Visit Preview Jun 29, 2023 7:34pm
sda-osmosis ❌ Failed (Inspect) Jun 29, 2023 7:34pm
sda-osmosis-testnet ❌ Failed (Inspect) Jun 29, 2023 7:34pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
dapp-legacy ⬜️ Ignored (Inspect) Jun 29, 2023 7:34pm

@NoahSaso NoahSaso merged commit 63ddbdc into development Jun 29, 2023
2 checks passed
@NoahSaso NoahSaso deleted the noah/paginate-nft branch June 29, 2023 19:49
@NoahSaso NoahSaso mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants