Skip to content

Commit

Permalink
Skips polars DB test on 3.12
Browse files Browse the repository at this point in the history
Why? It complains about connectorx not being installed.
But it is! and this only happens on python 3.12. Since
python 3.12 is so new, likely something has changed
in polars or connectorx. So skipping test for now on
3.12.
  • Loading branch information
skrawcz committed Mar 22, 2024
1 parent 120fc6f commit 269044f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tests/plugins/test_polars_extensions.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import pathlib
import sys

import polars as pl
import pytest

import polars as pl
from hamilton.plugins.polars_extensions import (
PolarsAvroReader,
PolarsAvroWriter,
Expand Down Expand Up @@ -119,6 +120,7 @@ def test_polars_avro(df: pl.DataFrame, tmp_path: pathlib.Path) -> None:
assert df.frame_equal(df2)


@pytest.mark.skipif(sys.version_info == (3, 12), reason="weird connectorx error on 3.12")
def test_polars_database(df: pl.DataFrame, tmp_path: pathlib.Path) -> None:
conn = f"sqlite:///{tmp_path}/test.db"
table_name = "test_table"
Expand Down

0 comments on commit 269044f

Please sign in to comment.