Skip to content

Commit

Permalink
Adds unit test for issue #948
Browse files Browse the repository at this point in the history
  • Loading branch information
elijahbenizzy committed Jun 12, 2024
1 parent 5a15d7c commit 44cbb73
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion tests/execution/test_graph_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,22 @@ def _inner(n: node.Node) -> bool:
"d",
),
({"a": [], "b": [], "c": ["a", "b"], "d": "c"}, {"c"}, "a", "d"),
# https://github.com/DAGWorks-Inc/hamilton/issues/948
(
{
"random_int": [],
"numbers": ["random_int"],
"add1": ["numbers", "random_int"],
"add2": ["add1", "random_int"],
"collect_numbers": ["add2"],
"final_result": ["collect_numbers"],
},
{"add1", "add2"},
"numbers",
"collect_numbers",
),
],
ids=["simple_base", "longer_chain", "complex_dag", "subdag_with_external_dep"],
ids=["simple_base", "longer_chain", "complex_dag", "subdag_with_external_dep", "issue_948"],
)
def test_find_nodes_between(dag_repr, expected_nodes_in_between, start_node, end_node):
nodes = _create_dummy_dag(dag_repr, dict_output=True)
Expand Down

0 comments on commit 44cbb73

Please sign in to comment.