Skip to content

Commit

Permalink
Fixing telemetry tests
Browse files Browse the repository at this point in the history
Need to set event count to higher since it seems to impact running tests.
  • Loading branch information
skrawcz committed Nov 22, 2024
1 parent 574501d commit 5bd0151
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tests/test_hamilton_driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import pandas as pd
import pytest

from hamilton import base, node
from hamilton import base, node, telemetry
from hamilton.caching.adapter import HamiltonCacheAdapter
from hamilton.driver import (
Builder,
Expand All @@ -25,6 +25,8 @@
import tests.resources.test_for_materialization
import tests.resources.very_simple_dag

telemetry.MAX_COUNT_SESSION = 100

"""This file tests driver capabilities.
Anything involving execution is tested for multiple executors/driver configuration.
Anything not involving execution is tested for just the single driver configuration.
Expand Down Expand Up @@ -235,6 +237,7 @@ def test_capture_constructor_telemetry(send_event_json):
assert actual_event_dict["event"] == "os_hamilton_run_start"
# validate schema
expected_properties = {
"$process_person_profile",
"os_type",
"os_version",
"python_version",
Expand Down
2 changes: 2 additions & 0 deletions tests/test_telemetry.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
from hamilton import async_driver, base, node, telemetry
from hamilton.lifecycle import base as lifecycle_base

telemetry.MAX_COUNT_SESSION = 100


@pytest.fixture
def blank_conf_file(tmp_path_factory):
Expand Down

0 comments on commit 5bd0151

Please sign in to comment.