Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: update references to external blogs on Hamilton #1046

Closed
skrawcz opened this issue Jul 19, 2024 · 8 comments · Fixed by #1208
Closed

Documentation: update references to external blogs on Hamilton #1046

skrawcz opened this issue Jul 19, 2024 · 8 comments · Fixed by #1208
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest Hacktoberfest issues hacktoberfest2024 hacktoberfest 2024

Comments

@skrawcz
Copy link
Collaborator

skrawcz commented Jul 19, 2024

Is your feature request related to a problem? Please describe.
We need to update https://hamilton.dagworks.io/en/latest/get-started/learning-resources/#external-blogs.

Describe the solution you'd like
We need to provide updates for blogs on Hamilton.

Some that come to mind:

Describe alternatives you've considered
N/A

Additional context
It would be great to semi-automate this. E.g. make updating this simpler to do, by running a command for example.

@skrawcz skrawcz added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 19, 2024
@skrawcz skrawcz changed the title Documentation: update blogs Documentation: update documentation references to external blogs on Hamilton Jul 19, 2024
@skrawcz skrawcz changed the title Documentation: update documentation references to external blogs on Hamilton Documentation: update references to external blogs on Hamilton Jul 19, 2024
@sikehish
Copy link
Contributor

I'd like to take this up!

@skrawcz
Copy link
Collaborator Author

skrawcz commented Oct 17, 2024

I'd like to take this up!

Great thank you. Assigned. I believe https://github.com/DAGWorks-Inc/hamilton/blob/main/docs/get-started/learning-resources.md is what you want to modify. Do you have an understanding of where and what to change?

@sikehish
Copy link
Contributor

If I've understood the issue correctly, we want to have the latest blogs in the external blogs section. Is that correct? If that's the case, then I was thinking if I could make use of a substack API(if it exists)/scrape https://substack.com/@dagworks/posts for the posts and then update the posts in external blog sections in the markdown file.

@skrawcz
Copy link
Collaborator Author

skrawcz commented Oct 17, 2024

If I've understood the issue correctly, we want to have the latest blogs in the external blogs section. Is that correct? If that's the case, then I was thinking if I could make use of a substack API(if it exists)/scrape https://substack.com/@dagworks/posts for the posts and then update the posts in external blog sections in the markdown file.

yep pretty much. You'd need to filter to posts that are about hamilton. Otherwise there's a few other posts that are linked in the issue that should also be added.

@sikehish
Copy link
Contributor

If I've understood the issue correctly, we want to have the latest blogs in the external blogs section. Is that correct? If that's the case, then I was thinking if I could make use of a substack API(if it exists)/scrape https://substack.com/@dagworks/posts for the posts and then update the posts in external blog sections in the markdown file.

yep pretty much. You'd need to filter to posts that are about hamilton. Otherwise there's a few other posts that are linked in the issue that should also be added.

Okay. So I guess I need to hardcode the other 4 posts. Is that right? And how many posts from substack should be added in learning-resources.md(programatically, through script, that is)?

@skrawcz
Copy link
Collaborator Author

skrawcz commented Oct 18, 2024

@sikehish yes that's fine.

I think using a date cut off is fine. Since that's how we'd update/run it. Pull posts older than X and add to the docs please :)

@sikehish
Copy link
Contributor

sikehish commented Oct 19, 2024

Hi @skrawcz . I was able to fetch the relevant data from blog.substack.io using headless web scraping. I'll start making the commits after the other PR #1194 gets through, to ensure that the commit history remains true to what the PR is.

@sikehish
Copy link
Contributor

HI @skrawcz . I've raised a PR #1208. Let me know if any changes need to be made.

@skrawcz skrawcz linked a pull request Oct 28, 2024 that will close this issue
7 tasks
@skrawcz skrawcz added hacktoberfest Hacktoberfest issues hacktoberfest2024 hacktoberfest 2024 labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest Hacktoberfest issues hacktoberfest2024 hacktoberfest 2024
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants