Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes that rely on config #109

Closed
elijahbenizzy opened this issue Mar 10, 2023 · 1 comment
Closed

Nodes that rely on config #109

elijahbenizzy opened this issue Mar 10, 2023 · 1 comment

Comments

@elijahbenizzy
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Some nodes need to be configured, and can't be known statically.
Say, for instance, you have one column for each month in a year. Or one task for each
file in a directory. We should be able to adjust the DAG without running code.

Describe the solution you'd like

A delayed decorator that doesn't resolve a decorator until after configuration is available.

Describe alternatives you've considered
Per-decorator delayed decorators.
Static data used with @parameterize
Not allowing this.
elijahbenizzy added a commit that referenced this issue Mar 10, 2023
@elijahbenizzy
Adds dyanmic node
5d8adb7 
See #109

Note this makes the following decisions:
1. Chooses to use the generic `@dynamic` decorator
2. Buries it under a power-user mode
3. Uses the parameter names of the labmda/function to draw from the
   config
elijahbenizzy added a commit that referenced this issue Mar 10, 2023
@elijahbenizzy
Adds dyanmic node
a4eb9fd 
See #109

Note this makes the following decisions:
1. Chooses to use the generic `@dynamic` decorator
2. Buries it under a power-user mode
3. Uses the parameter names of the labmda/function to draw from the
   config
elijahbenizzy added a commit that referenced this issue Mar 11, 2023
@elijahbenizzy
Adds dyanmic node
4b4f996 
See #109

Note this makes the following decisions:
1. Chooses to use the generic `@dynamic` decorator
2. Buries it under a power-user mode
3. Uses the parameter names of the labmda/function to draw from the
   config
elijahbenizzy added a commit that referenced this issue Mar 12, 2023
@elijahbenizzy
Adds dyanmic node
2038d1f 
See #109

Note this makes the following decisions:
1. Chooses to use the generic `@dynamic` decorator
2. Buries it under a power-user mode
3. Uses the parameter names of the labmda/function to draw from the
   config
elijahbenizzy added a commit that referenced this issue Mar 12, 2023
@elijahbenizzy
Adds dynamic node
64f6eed 
See #109

Note this makes the following decisions:
1. Chooses to use the generic `@dynamic` decorator
2. Buries it under a power-user mode
3. Uses the parameter names of the labmda/function to draw from the
   config

We also Deprecate dynamic_transform

This was an old way of doing the same thing. This was never accessible
to users, as it reuqired implementing a subclass and konwing some of
hamilton's internals. delay_resolution solves the same problem, and
gives users access to any of the current decorators.
elijahbenizzy added a commit that referenced this issue Mar 12, 2023
@elijahbenizzy
Adds dynamic node
5e21e4b 
See #109

Note this makes the following decisions:
1. Chooses to use the generic `@dynamic` decorator
2. Buries it under a power-user mode
3. Uses the parameter names of the labmda/function to draw from the
   config

We also Deprecate dynamic_transform

This was an old way of doing the same thing. This was never accessible
to users, as it reuqired implementing a subclass and konwing some of
hamilton's internals. delay_resolution solves the same problem, and
gives users access to any of the current decorators.
elijahbenizzy added a commit that referenced this issue Mar 13, 2023
@elijahbenizzy
Adds dynamic node
1803500 
See #109

Note this makes the following decisions:
1. Chooses to use the generic `@dynamic` decorator
2. Buries it under a power-user mode
3. Uses the parameter names of the labmda/function to draw from the
   config

We also Deprecate dynamic_transform

This was an old way of doing the same thing. This was never accessible
to users, as it reuqired implementing a subclass and konwing some of
hamilton's internals. delay_resolution solves the same problem, and
gives users access to any of the current decorators.
elijahbenizzy added a commit that referenced this issue Mar 13, 2023
@elijahbenizzy
Adds dynamic node
3988284 
See #109

Note this makes the following decisions:
1. Chooses to use the generic `@dynamic` decorator
2. Buries it under a power-user mode
3. Uses the parameter names of the labmda/function to draw from the
   config

We also Deprecate dynamic_transform

This was an old way of doing the same thing. This was never accessible
to users, as it reuqired implementing a subclass and konwing some of
hamilton's internals. delay_resolution solves the same problem, and
gives users access to any of the current decorators.
elijahbenizzy added a commit that referenced this issue Mar 13, 2023
@elijahbenizzy
Adds dynamic node
879b66b 
See #109

Note this makes the following decisions:
1. Chooses to use the generic `@dynamic` decorator
2. Buries it under a power-user mode
3. Uses the parameter names of the labmda/function to draw from the
   config

We also Deprecate dynamic_transform

This was an old way of doing the same thing. This was never accessible
to users, as it reuqired implementing a subclass and konwing some of
hamilton's internals. delay_resolution solves the same problem, and
gives users access to any of the current decorators.
elijahbenizzy added a commit that referenced this issue Mar 16, 2023
@elijahbenizzy
Adds dynamic node
943cc4b 
See #109

Note this makes the following decisions:
1. Chooses to use the generic `@dynamic` decorator
2. Buries it under a power-user mode
3. Uses the parameter names of the labmda/function to draw from the
   config

We also Deprecate dynamic_transform

This was an old way of doing the same thing. This was never accessible
to users, as it reuqired implementing a subclass and konwing some of
hamilton's internals. delay_resolution solves the same problem, and
gives users access to any of the current decorators.
elijahbenizzy added a commit that referenced this issue Mar 16, 2023
@elijahbenizzy
Adds dynamic node
f47f9b1 
See #109

Note this makes the following decisions:
1. Chooses to use the generic `@dynamic` decorator
2. Buries it under a power-user mode
3. Uses the parameter names of the labmda/function to draw from the
   config

We also Deprecate dynamic_transform

This was an old way of doing the same thing. This was never accessible
to users, as it reuqired implementing a subclass and konwing some of
hamilton's internals. delay_resolution solves the same problem, and
gives users access to any of the current decorators.
@elijahbenizzy
Copy link
Collaborator Author

This has been fixed and released in 1.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elijahbenizzy