Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reusing_functions #1179

Closed
skrawcz opened this issue Oct 14, 2024 · 1 comment · Fixed by #1189
Closed

reusing_functions #1179

skrawcz opened this issue Oct 14, 2024 · 1 comment · Fixed by #1189
Assignees
@eoagyen
Labels
hacktoberfest Hacktoberfest issues

Comments

@skrawcz
Copy link
Collaborator

skrawcz commented Oct 14, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

A lot of DS want a notebook to get started with, not a python script -- these can be too intimidating.

Describe the solution you'd like

We should make sure our examples all have a jupyter notebook to mirror the "run.py" file. That way people can see how things are exercised and then they can use a notebook to try things out. Note: we should use the jupyter_magic where appropriate in the notebook.

E.g. we want each example to have a notebook kind of like the hello world example.

This issue is for the reusing_functions example.
@skrawcz skrawcz mentioned this issue Oct 14, 2024
Open
19 tasks
@eoagyen
Copy link
Contributor

eoagyen commented Oct 14, 2024

@skrawcz I will work on this issue. Thanks

skrawcz added a commit that referenced this issue Oct 16, 2024
@eoagyen @skrawcz
Jupyter notebook for reusing_functions example (reusing_functions #1179…
7b9f52a 
…) (#1189)

Updates example to have jupyter notebook variant.

* Jupyter notebook for reusing_functions example

* Update reusing_functions.ipynb

removing import -- not needed.

* Update reusing_functions.ipynb

updates driver creation to latest approach.

---------

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
@skrawcz skrawcz linked a pull request Oct 16, 2024 that will close this issue
Jupyter notebook for reusing_functions example (reusing_functions #1179) #1189
Merged
7 tasks
@skrawcz skrawcz added the hacktoberfest Hacktoberfest issues label Oct 16, 2024
@skrawcz skrawcz closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eoagyen eoagyen

Labels
hacktoberfest Hacktoberfest issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jupyter notebook for reusing_functions example (reusing_functions #1179) eoagyen/hamilton
2 participants
@skrawcz @eoagyen