Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version field to metadata collected from files and dataframes #1036

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Jul 18, 2024

Adds version field to metadata collected for files and dataframes.

Implements #751.

This is to formalize schema at a Hamilton level.

We can always extend this to have someone provide
their own callback function to produce this.

We use the __ syntax to help show that this is internal.

Changes

io/utils metadata functions.

How I tested this

  • locally via unit tests

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Implements #751.

This is to formalize schema at a Hamilton level.

We can always extend this to have someone provide
their own callback function to produce this.
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@elijahbenizzy elijahbenizzy marked this pull request as ready for review September 10, 2024 16:26
@elijahbenizzy elijahbenizzy merged commit 62d045d into main Sep 10, 2024
24 checks passed
@elijahbenizzy elijahbenizzy deleted the add_version branch September 10, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants