Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds doc contrasting/comparing Hamilton with other systems. #106

Merged
merged 9 commits into from
Mar 9, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

This will asnwer a lot of FAQs -- how does Hamilton compare with X. We can have the authors of X add to this page as well.

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

This will asnwer a lot of FAQs -- how does Hamilton compare with X.
We can have the authors of X add to this page as well.
@elijahbenizzy elijahbenizzy requested a review from skrawcz March 9, 2023 00:42
@elijahbenizzy elijahbenizzy marked this pull request as ready for review March 9, 2023 00:42
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with my changes 😁

docs/concepts/hamilton-v-x.md Outdated Show resolved Hide resolved
docs/concepts/hamilton-v-x.md Outdated Show resolved Hide resolved
docs/concepts/hamilton-v-x.md Outdated Show resolved Hide resolved
docs/concepts/hamilton-v-x.md Outdated Show resolved Hide resolved
docs/concepts/hamilton-v-x.md Outdated Show resolved Hide resolved
docs/concepts/hamilton-v-x.md Outdated Show resolved Hide resolved
docs/concepts/hamilton-v-x.md Outdated Show resolved Hide resolved
docs/concepts/hamilton-v-x.md Outdated Show resolved Hide resolved
elijahbenizzy and others added 8 commits March 8, 2023 20:57
Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
@skrawcz skrawcz merged commit e531c39 into main Mar 9, 2023
@skrawcz skrawcz deleted the add-comparison-docs branch March 9, 2023 07:16
elijahbenizzy added a commit that referenced this pull request Mar 13, 2023
* Adds doc contrasting/comparing Hamilton with other systems.

This will answer a lot of FAQs -- how does Hamilton compare with X.
We can have the authors of X add to this page as well.

* Update docs/concepts/hamilton-v-x.md

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

* Update docs/concepts/hamilton-v-x.md

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

* Update docs/concepts/hamilton-v-x.md

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

* Update docs/concepts/hamilton-v-x.md

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

* Update docs/concepts/hamilton-v-x.md

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

* Update docs/concepts/hamilton-v-x.md

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

* Update docs/concepts/hamilton-v-x.md

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

* Update docs/concepts/hamilton-v-x.md

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>

---------

Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants