Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds NoEdgeAndInputTypeChecking adapter #1067

Merged
merged 3 commits into from
Jul 27, 2024
Merged

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Jul 26, 2024

So that people can turn off type checking if they really want to.

This won't necessarily mean you can get away without types -- it just means they don't need to match.

Changes

  • adds adapter
  • updates docs

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz skrawcz requested a review from elijahbenizzy July 26, 2024 06:13
skrawcz added 3 commits July 26, 2024 20:42
 So that people can turn off type checking if they really want to.

This won't necessarily mean you can get away without types -- it just means
they don't need to match.
@skrawcz skrawcz force-pushed the add_no_input_typechecking branch from 7318eec to dc84842 Compare July 27, 2024 04:26
@skrawcz skrawcz merged commit 31d3b62 into main Jul 27, 2024
24 checks passed
@skrawcz skrawcz deleted the add_no_input_typechecking branch July 27, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants