Plugin/mlflow custom flavor - fixed small bug #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jernejfrank ! For the pre-commit failure you just need to do something like:
|
|
I'll plan to push this in the release on Monday. If you don't get to the |
skrawcz
requested changes
Jul 26, 2024
skrawcz
approved these changes
Jul 27, 2024
|
Thanks @jernejfrank ! |
skrawcz
merged commit ff40dd4
into
DAGWorks-Inc:plugin/mlflow-custom-flavor
24 checks passed
skrawcz
pushed a commit
that referenced
this pull request
Jul 27, 2024
Thanks for adding the custom flavor option to mlflow. I tested it and only the flavor specific kwargs somehow got mixed up and tried to be called somewhere else which lead to a fatal error. Changes renamed class attribute to avoid conflicting calls How I tested this added unit test that doubles as minimal example for reproducing the error Notes only tested the DataSaver (due to internal legacy structure, DataLoader is not utilised/hard to implement) * working mlflow plugin need to add kwargs for custom flavor * flavor kwargs used outside of mlflow saver/loader class * updated class description * flavor kwargs used outside of mlflow saver/loader class * removed incidental files --------- Co-authored-by: Jernej Frank <jernej.frank@oxehealth.com>
skrawcz
added a commit
that referenced
this pull request
Jul 29, 2024
Before, the MLFlow plugin would allow for 2 main patterns. ```python to.mlflow(...) # infer the flavor to.mlflow(..., flavor="sklearn") # mlflow supported flavor ``` ^Note that this should support the pyfunc flavor, which is a convenient way to create custom estimators (MLFlow reference) Now, we can also pass in modules for mlflow flavors: ```python import custom_flavor to.mlflow(..., flavor=custom_flavor) ``` consequently, this would also work ``` import mlflow to.mlflow(..., flavor=mlflow.sklearn) ``` Squashed commits: * saver and loader now accept ModuleType for flavor kwarg * Plugin/mlflow custom flavor - fixed small bug (#1068) Thanks for adding the custom flavor option to mlflow. I tested it and only the flavor specific kwargs somehow got mixed up and tried to be called somewhere else which lead to a fatal error. Changes renamed class attribute to avoid conflicting calls How I tested this added unit test that doubles as minimal example for reproducing the error Notes only tested the DataSaver (due to internal legacy structure, DataLoader is not utilised/hard to implement) * working mlflow plugin need to add kwargs for custom flavor * flavor kwargs used outside of mlflow saver/loader class * updated class description * flavor kwargs used outside of mlflow saver/loader class * removed incidental files --------- Co-authored-by: Jernej Frank <jernej.frank@oxehealth.com> * Adds ML loader test for kwargs To complement saver. --------- Co-authored-by: zilto <tjean@DESKTOP-V6JDCS2> Co-authored-by: jernejfrank <50105951+jernejfrank@users.noreply.github.com> Co-authored-by: Jernej Frank <jernej.frank@oxehealth.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for adding the custom flavor option to mlflow. I tested it and only the flavor specific kwargs somehow got mixed up and tried to be called somewhere else which lead to a fatal error.
Changes
How I tested this
Notes
Checklist