Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PandasExcelWriter to use pd.ExcelWriter #1078

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

noahridge
Copy link
Contributor

@noahridge noahridge commented Aug 2, 2024

Created to fix issue #946 -- PandasExcelWriter overwrites file

Changes

Changes to pandas_extensions.py in PandasExcelWriter to implement the pd.ExcelWriter and add appropriate keyword arguments to support this.

How I tested this

Locally via existing unit tests

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz
Copy link
Collaborator

skrawcz commented Aug 3, 2024

Looking good. Mind adding a link to https://pandas.pydata.org/docs/reference/api/pandas.ExcelWriter.html on line 1484.
Otherwise anything else to be done? It doesn't appear you need a specific unit test for this right?

@noahridge
Copy link
Contributor Author

Thanks, I added the link in the docstring for PandasExcelWriter. Otherwise, I think everything should be ready.

There is an existing unit test under tests/plugins/test_pandas_extensions.py which tests the PandasExcelWriter and .save_data() method, so I don't think anything needs to be added here.

@noahridge noahridge marked this pull request as ready for review August 6, 2024 03:53
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thanks @noahridge !

@skrawcz skrawcz merged commit 7b84fdd into DAGWorks-Inc:main Aug 6, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants