Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to packaging & configuration using pyproject.toml #1088

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Dev-iL
Copy link
Contributor

@Dev-iL Dev-iL commented Aug 7, 2024

Transition to the more modern pyproject.toml from setup.cfg, requirements-*.txt etc.

Changes

Combined multiple files into one + added some placeholder for ruff & mypy.

How I tested this

python -m build --wheel

Notes

Addresses #10

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@Dev-iL Dev-iL force-pushed the dev-il/2408/pyproject-toml branch 5 times, most recently from a5499d9 to 65329fd Compare August 7, 2024 20:50
This includes some configurations for ruff, which will be enabled in an upcoming PR.
@Dev-iL Dev-iL force-pushed the dev-il/2408/pyproject-toml branch from 65329fd to 6eb1b2c Compare August 8, 2024 06:54
@Dev-iL Dev-iL marked this pull request as ready for review August 8, 2024 07:09
setup.py Show resolved Hide resolved
@skrawcz
Copy link
Collaborator

skrawcz commented Aug 8, 2024

This fixes #10

@skrawcz skrawcz merged commit c402a69 into DAGWorks-Inc:main Aug 8, 2024
24 checks passed
@skrawcz
Copy link
Collaborator

skrawcz commented Aug 8, 2024

thanks @Dev-iL !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants