Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes edge cases input type checking missed #1091

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Aug 12, 2024

This handles sequences and literals.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

See squashed commits:

Adds range test (+2 squashed commits)
Squashed commits:
[114b161] Fixes set & sequence checks

So that they're correct.
[6dec56e] Fixes edge cases input type checking missed

This handles sequences and literals.
Updates doc string to show example usage.
This was missed. Now it mirrors the other driver.
@skrawcz skrawcz force-pushed the fix_input_type_checking branch from 0d4394b to 2032e3a Compare August 14, 2024 05:59
@skrawcz skrawcz merged commit 994b6ee into main Aug 14, 2024
9 of 24 checks passed
@skrawcz skrawcz deleted the fix_input_type_checking branch August 14, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant