Update the check_for_changes
job in CI
#1140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per my conversation with @elijahbenizzy in #1121 I have updated the
check_for_changes
job in the CI configuration file so that it compares againstmain
(vice the previous commitHEAD^
). This will hopefully allow CI to detect changes in multi-commit pushes.Changes
I updated the
check_for_changes
job in./circleci/config.yml
to usegit diff --name-only origin/main...HEAD
.How I tested this
I made a mulit-commit push where the first commit alters
./circleci/config.yml
and the second commit is empty. The newcheck_for_changes
command should detect the changes in./circleci/config.yml
and run the tests.Notes
I will remove all test commits before merging into main!
Checklist