Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the check_for_changes job in CI #1140

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

cswartzvi
Copy link
Contributor

@cswartzvi cswartzvi commented Sep 13, 2024

As per my conversation with @elijahbenizzy in #1121 I have updated the check_for_changes job in the CI configuration file so that it compares against main (vice the previous commit HEAD^). This will hopefully allow CI to detect changes in multi-commit pushes.

Changes

I updated the check_for_changes job in ./circleci/config.yml to use git diff --name-only origin/main...HEAD.

How I tested this

I made a mulit-commit push where the first commit alters ./circleci/config.yml and the second commit is empty. The new check_for_changes command should detect the changes in ./circleci/config.yml and run the tests.

Notes

I will remove all test commits before merging into main!

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy
Copy link
Collaborator

So this looks correct to me, and appears to be correct, on itself! IMO good enough for now even though there are definitely improvements we can make medium term.

@elijahbenizzy elijahbenizzy self-requested a review September 13, 2024 21:00
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd like to squash + rebase this so you can rebase on top of that if that's OK.

@elijahbenizzy elijahbenizzy merged commit 92643da into DAGWorks-Inc:main Sep 14, 2024
24 checks passed
@cswartzvi cswartzvi deleted the check_changes_command branch September 14, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants