Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command options to install dependency. #1141

Conversation

seyawudba
Copy link
Contributor

--- PR TEMPLATE INSTRUCTIONS (2) ---

This change was necessary to allow users install dependencies seamlessly without any problems.

Changes

  • Extra commands were added to the developer_setup.md file to allow users whose terminals wouldn't execute the dependency install command to also install dependencies without any struggle.

How I tested this

  • A preview was made in the vscode editor to see how the changes would look when pushed.
  • The pre-commit checks were also run and everything passed successfully.

Notes

  • I didn't remove the earlier command because I think it might work for users.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

```shell
pip install .\[dev,test\]

pip install '.[dev,test]'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second one (single quotes) should always work -- just have that without square brackets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please come clearer on your question?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two pip install commands. Do we need both?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, both of them work but I had to remove one. So I think we are good.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! I merged it.

Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@elijahbenizzy elijahbenizzy merged commit 3ed61dd into DAGWorks-Inc:main Sep 15, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants