Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-hoc feedback from #1145 #1151

Merged
merged 1 commit into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/scikit-learn/species_distribution_modeling/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ qux(baz(foo(bar)))
```

This can be particularly useful when:
1. Ensuring consi
1. Ensuring consistency between transforms/data processing steps across different nodes.
2. Re-using the same function on multiple nodes. For example, needing to do different pre-processing, but than passing data to the same `model`, aka feature engineering hyper-tuning.
3. We can also use `step(...).when(...)` and can choose at execution time which transformation will be applied to the output of a particular node. For example, each `step` represents a different `model` and we switch between them with a config dictionary in the Hamilton driver.

Expand All @@ -70,7 +70,7 @@ so that it does not run when imported into other scripts.
This script can be run as is for comparison. Actually the external functions `construct_grids()` and `create_species_bunch()` we will directly import and use as external functions to showcase how you can use our `pipe` and `pipe_output` functionality to "Hamiltonise" external modules.

## hamilton_notebook.ipynb
Is a nodebook that contains all the modules and has the execution cells to run the complete code. It also gives you the ability to visualize the DAG.
Is a notebook that contains all the modules and has the execution cells to run the complete code. It also gives you the ability to visualize the DAG.

## run.py
If you prefer to run code through a shell the same code is also available as a python script.
Expand Down
2 changes: 1 addition & 1 deletion hamilton/function_modifiers/macros.py
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ def B(...):
B1, takes the output of B1 applies to it B2 and then gets renamed to B to re-connect to the rest of the DAG.

While it is generally reasonable to contain these constructs within a node's function,
you should consider `pipe_output` for similar reasons as `pipe`, namely, for any of the following reasons:
you should consider `pipe_output` for similar reasons as `pipe_input`, namely, for any of the following reasons:

1. You want the transformations to display as nodes in the DAG, with the possibility of storing or visualizing
the result
Expand Down