Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to allow nesting of subdags #116

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Fixes to allow nesting of subdags #116

merged 2 commits into from
Mar 21, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

decorators

Every decorator should have access to this, just in case, so we don't have to worry about passing it through. This changes the resolve_config function in function_modifiers.base to pass it through globally. Note that this also removes the default setting of this in the @resolve(...) decorator as it is no longer necessary.

Furthermore, this cleans up some issues in which the optional configs provided by a decorator was a list instead of a dictionary.

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

decorators

Every decorator should have access to this, just in case, so we don't
have to worry about passing it through. This changes the resolve_config
function in function_modifiers.base to pass it through globally. Note
that this also *removes* the default setting of this in the @resolve(...)
decorator as it is no longer necessary.

Furthermore, this cleans up some issues in which the optional configs
provided by a decorator was a list instead of a dictionary.
@elijahbenizzy elijahbenizzy requested a review from skrawcz March 21, 2023 00:30
This was previously banned for no reason other than I didn't see a
reason to enable it. Now people have been asking for it, and its
well-worth the effort.
@elijahbenizzy elijahbenizzy merged commit 9f8ac09 into main Mar 21, 2023
@elijahbenizzy elijahbenizzy deleted the nested-subdags branch March 21, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants