Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update using #1164

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Update using #1164

merged 2 commits into from
Oct 3, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Oct 3, 2024

Updates info on using and some updated links to external content.

Changes

  • docs
  • readme

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a566c2a in 4 seconds

More details
  • Looked at 110 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. examples/feature_engineering/README.md:3
  • Draft comment:
    Consider adding a brief description of the examples provided to give users context on what they demonstrate or aim to teach.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The README.md file in the examples/feature_engineering directory is very minimal and lacks context about the examples provided. It would be beneficial to include a brief description of what each example demonstrates or aims to teach.
2. examples/feature_engineering/README.md:1
  • Draft comment:
    Consider adding a reference to this new example in the sphinx documentation under docs/ to ensure it's included in the official documentation.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR includes a new README file in the examples directory, which should be documented in the sphinx documentation under docs/.

Workflow ID: wflow_X7jinwTQqpSbVKFP


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@skrawcz skrawcz merged commit c400290 into main Oct 3, 2024
24 checks passed
@skrawcz skrawcz deleted the update_using branch October 3, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant