Adds better formatted slack notifications #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
force-pushed
the
slack-notification-improvements
branch
from
64e74fa to
fc38175
Compare
skrawcz
approved these changes
Oct 7, 2024
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to fc38175 in 13 seconds
More details
- Looked at
31lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. hamilton/plugins/h_slack.py:78
- Draft comment:
Use triple backticks consistently for code blocks and single backticks for inline code. The current usage of backticks in the message formatting is inconsistent. - Reason this comment was not posted:
Confidence changes required:50%
The use of backticks in the Slack message formatting is inconsistent. The backticks should be consistent for code blocks and inline code.
Workflow ID: wflow_abWaWxcuUrJWRt8o
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| f"> *Error:* {str(error)}\n" | ||
| f"> *Stack Trace:*\n> ```\n{''.join(traceback.format_exception(type(error), error, error.__traceback__))}```\n" | ||
| f"> *Node Tags:* `{node_tags}`\n" | ||
| f"> *Node Kwargs:* ```{create_input_string(node_kwargs)}```\n" |
There was a problem hiding this comment.
Avoid logging potentially sensitive data such as node_kwargs. Consider sanitizing or removing sensitive information before logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Solves:
How I tested this
Ran locally
Notes
Checklist