Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed syntax error in code block for parameterized_subdag #1171

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

sT0v
Copy link
Contributor

@sT0v sT0v commented Oct 8, 2024

Fixed syntax error in code block for parameterized_subdag

How I tested this

Pasted in vscode to validate formatting it correct

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ca0440b in 40 seconds

More details
  • Looked at 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. hamilton/function_modifiers/recursive.py:505
  • Draft comment:
    Missing closing parenthesis in the example code block for parameterized_subdag. Add a closing parenthesis to ensure the example is accurate.
                "inputs" : {"data" : value("datasource_3.csv")},
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is about a change made in the diff, specifically the correction of missing closing parentheses. The comment is accurate as it points out an issue that was present in the original code and has been addressed in the changes. The comment is actionable and clear, suggesting a specific correction that aligns with the changes made.
    I might be missing the fact that the issue has already been resolved in the diff, which would make the comment redundant. The comment might not be necessary if the change has already been made.
    The comment is still useful as it confirms that the change made in the diff was necessary and correct. It serves as a validation of the correction made.
    The comment is correct and should be kept as it accurately points out an issue that was addressed in the changes. It confirms the necessity of the change made in the diff.

Workflow ID: wflow_HOLu26TcdxLk95eB


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@elijahbenizzy elijahbenizzy self-requested a review October 8, 2024 15:25
@elijahbenizzy
Copy link
Collaborator

Thank you @sT0v!

@elijahbenizzy elijahbenizzy merged commit 05cf57d into DAGWorks-Inc:main Oct 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants