Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows layering of subdag and extract_* #120

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Conversation

elijahbenizzy
Copy link
Collaborator

@elijahbenizzy elijahbenizzy commented Mar 22, 2023

This solves #72 and #115.

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy elijahbenizzy force-pushed the decorator-improvements branch 3 times, most recently from 3c5791b to 29d6150 Compare March 23, 2023 03:23
This solves #72. This is done by introducing a new base class decorator
SingleNodeNodeTransformer that extends from NodeTransformer. This is
meant to replace `NodeExpander`, as it allows transformers to run on a
subdag that outputs a single "final" node (a sink). Note that, in this
case, decorator ordering *will* matter.
@elijahbenizzy elijahbenizzy force-pushed the decorator-improvements branch from 29d6150 to 523da36 Compare March 23, 2023 03:26
@elijahbenizzy elijahbenizzy requested a review from skrawcz March 23, 2023 03:27
@elijahbenizzy elijahbenizzy merged commit be630a3 into main Mar 23, 2023
@elijahbenizzy elijahbenizzy deleted the decorator-improvements branch March 23, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants