Bugfix pipe_output after config.when resolution

[jernejfrank]

Addressing #1218

For pipe_output

@pipe_output(
    step(_foo).when(key="foo"),
    step(_bar).when(key="bar"),
)
def filtered_data(raw_data: pd.DataFrame) -> pd.DataFrame:
    return ...

in case no conditions are met, e.g. config={"key":"skip"}, it returns filtered_dataas ifpipe_output` isn't there.

I think this is better than raising an error since it leaves the ability to choose transforms at runtime (which is related to using config.when on any other function in the DAG).

I also amended tests to capture this.

[sweep-ai]

Hey @jernejfrank, here is an example of how you can ask me to improve this pull request:

@Sweep Add a unit test specifically for the edge case where no conditions are met in the `pipe_output` decorator, testing the behavior with different config values that do not match any conditions.

📖 For more information on how to use Sweep, please read our documentation.

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to ff864e3 in 1 minute and 14 seconds

More details

• Looked at 132 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. hamilton/function_modifiers/macros.py:1317

• Draft comment:
  The logic in transform_node is complex and involves multiple steps and conditions. Consider adding comments to explain the process, especially where the original node is returned if no transforms are applied.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_DST30BFmXzRHGoVS

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[skrawcz]

Thanks @jernejfrank !