Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helpful exception message for .visualize_execution() #1226

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Nov 13, 2024

After a chat with a user, I opened #1185. After looking at it, this feature is already implemented via .visualize_execution(..., bypass_validation=True). I updated the exception handling to provide an helpful message

@zilto zilto added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 13, 2024
@zilto zilto changed the title added helpful exception message helpful exception message for .visualize_execution() Nov 13, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 13bf4f0 in 24 seconds

More details
  • Looked at 23 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. hamilton/driver.py:984
  • Draft comment:
    The comment about Python 3.11 enabling .add_note() is unnecessary here since the code does not use that syntax. Consider removing it for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The exception handling logic is correct, but the comment about Python 3.11 is unnecessary and could be misleading since the code does not use the .add_note() syntax.
2. hamilton/driver.py:981
  • Draft comment:
    Add a comment explaining the purpose of the try-except block for handling validation exceptions and adding a helpful message.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code in the PR adds a helpful exception message when validation fails. This is a good addition for user experience. However, the code could benefit from a comment explaining the purpose of the try-except block, as it involves exception handling logic that might not be immediately clear to all developers.

Workflow ID: wflow_IH0MwnwpJ60THCEe


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@zilto zilto merged commit 18a12c0 into main Nov 13, 2024
24 checks passed
@zilto zilto deleted the feat/visualize-execution-without-inputs branch November 13, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants