Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1240 #1241

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fixes #1240 #1241

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e46872
Fixes #1240
skrawcz Nov 24, 2024
e12b943
Adds tests
skrawcz Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions hamilton/caching/stores/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import inspect
import shutil
from pathlib import Path
from typing import Any, Optional
Expand Down Expand Up @@ -68,8 +69,24 @@ def set(
if saver_cls is not None:
# materialized_path
materialized_path = self._materialized_path(data_version, saver_cls)
saver = saver_cls(path=str(materialized_path.absolute()))
loader = loader_cls(path=str(materialized_path.absolute()))
saver_argspec = inspect.getfullargspec(saver_cls.__init__)
skrawcz marked this conversation as resolved.
Show resolved Hide resolved
loader_argspec = inspect.getfullargspec(loader_cls.__init__)
if "file" in saver_argspec.args:
saver = saver_cls(file=str(materialized_path.absolute()))
elif "path" in saver_argspec.args:
saver = saver_cls(path=str(materialized_path.absolute()))
else:
raise ValueError(
f"Saver [{saver_cls.name()}] must have either `file` or `path` as an argument."
)
if "file" in loader_argspec.args:
loader = loader_cls(file=str(materialized_path.absolute()))
elif "path" in loader_argspec.args:
loader = loader_cls(path=str(materialized_path.absolute()))
else:
raise ValueError(
f"Loader [{loader_cls.name()}] must have either `file` or `path` as an argument."
)
else:
saver = None
loader = None
Expand Down