Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps version to 1.83.3 #1244

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Bumps version to 1.83.3 #1244

merged 1 commit into from
Nov 26, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Nov 26, 2024

To push out patch fixes.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

To push out patch fixes.
@skrawcz skrawcz merged commit 10f8f91 into main Nov 26, 2024
1 of 5 checks passed
@skrawcz skrawcz deleted the bump_version branch November 26, 2024 01:03
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 01c7d8e in 4 seconds

More details
  • Looked at 7 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. hamilton/version.py:1
  • Draft comment:
    Ensure the checklist in the PR description is completed before merging. This helps maintain best practices and ensures all necessary steps are followed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR is straightforward, updating the version number. However, the checklist in the PR description is not completed, which is a best practice to ensure all necessary steps are followed before merging.
2. hamilton/version.py:1
  • Draft comment:
    Consider adding a note in the docs/ to document this version change for better tracking and clarity.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The version bump is straightforward and doesn't violate any of the specified rules. However, it would be beneficial to document this change in the project documentation.

Workflow ID: wflow_KZMxvLyMhU0EfuAK


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant