Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps version from 1.83.3 to 1.84.0 #1248

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

elijahbenizzy
Copy link
Collaborator

No description provided.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1232f8f in 4 seconds

More details
  • Looked at 22 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pyproject.toml:60
  • Draft comment:
    Ensure that the latest release of 'furo' includes the necessary features or fixes that were previously required from the main branch.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from a specific GitHub branch to a package version for 'furo' is correct, but it should be verified if the latest release of 'furo' includes the necessary features or fixes that were previously required from the main branch.

Workflow ID: wflow_sLlOv8MTInI1hAVV


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 8a0b027 in 2 seconds

More details
  • Looked at 7 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. hamilton/version.py:1
  • Draft comment:
    Version bump looks correct and follows semantic versioning.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version bump seems correct and consistent with semantic versioning practices. No issues found.
2. hamilton/version.py:1
  • Draft comment:
    Consider adding this version change to the docs/ for tracking purposes.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The PR is a simple version bump, which is fine. However, it would be beneficial to add this change to the documentation for tracking purposes.

Workflow ID: wflow_X7BLhBlQ2AGtyqbx


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@elijahbenizzy elijahbenizzy merged commit 9ef9b08 into main Dec 4, 2024
2 of 24 checks passed
@elijahbenizzy elijahbenizzy deleted the version-bump-1.84.0 branch December 4, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant