Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks xfail xgboost test due to scikit lib issue #1255

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Dec 12, 2024

Skips because we're seeing:

AttributeError: 'super' object has no attribute 'sklearn_tags'
due to new library version rolling out and xgboost not being updated yet.

Changes

  • mark xfail for flaky test

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Skips because we're seeing:
 > AttributeError: 'super' object has no attribute '__sklearn_tags__'
due to new library version rolling out and xgboost not being updated yet.
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c2c3b03 in 17 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. tests/plugins/test_xgboost_extensions.py:37
  • Draft comment:
    The xfail mark is applied with condition=True, meaning the test is expected to fail unconditionally. Ensure to revisit this once the library incompatibility is resolved.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The xfail mark is applied with condition=True, which means it will always expect the test to fail. This is appropriate given the PR description, but it should be noted that this is a temporary measure until the library incompatibility is resolved.
2. tests/plugins/test_xgboost_extensions.py:38
  • Draft comment:
    Function and method names should follow consistent patterns. Consider renaming test_xgboost_model_json_reader and other test functions to maintain consistency in naming conventions.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_EapOU3s7moOMiY8d


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

So new version of numpy doesn't have the same behavior for 3.9 as
for 3.10+.
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 3060b64 in 31 seconds

More details
  • Looked at 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. tests/test_node.py:63
  • Draft comment:
    Consider using more descriptive variable names for major and minor, such as numpy_major_version and numpy_minor_version, to improve code readability. This applies to line 48 as well.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_EhsVp2uCVlE6onWA


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -60,14 +60,15 @@ def annotated_func(first: ArrayN[np.float64], other: float = 2.0) -> ArrayN[np.f

node = Node.from_fn(annotated_func)
assert node.name == "annotated_func"
if major == 2 and minor > 1: # greater that 2.1
if major == 2 and minor > 1 and sys.version_info > (3, 9): # greater that 2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition sys.version_info > (3, 9) should be sys.version_info >= (3, 9) to correctly include Python 3.9 and above.

@elijahbenizzy elijahbenizzy merged commit 25573bf into main Dec 12, 2024
24 checks passed
@elijahbenizzy elijahbenizzy deleted the skip_xgboost_test branch December 12, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants