Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a few more SQL commands for snowflake example #1258

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Dec 17, 2024

Adds a few more SQL commands for snowflake example

Changes

  • snowflake UI example

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 22c0c86 in 33 seconds

More details
  • Looked at 45 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. examples/snowflake/hamilton_ui/pipeline_endpoint.py:89
  • Draft comment:
    Fixed logical bug: Corrected the order of parameters when creating pandas Series for 'signups' and 'spend'. This fix is also applicable to line 90.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_o9kE2q132Uip6UX0


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

examples/snowflake/hamilton_ui/snowflake.sql Show resolved Hide resolved
examples/snowflake/hamilton_ui/snowflake.sql Show resolved Hide resolved
@skrawcz skrawcz merged commit 9f6ea84 into main Dec 17, 2024
22 of 24 checks passed
@skrawcz skrawcz deleted the update_snowflake_example branch December 17, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant