Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update base.py #1262

Merged
merged 1 commit into from
Dec 24, 2024
Merged

chore: update base.py #1262

merged 1 commit into from
Dec 24, 2024

Conversation

eltociear
Copy link
Contributor

Changes

occured -> occurred

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

occured -> occurred
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to caea19c in 7 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. hamilton/function_modifiers/base.py:775
  • Draft comment:
    Typo fix: 'occured' corrected to 'occurred'. This is a straightforward correction.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR is a simple typo fix, changing 'occured' to 'occurred'. This is a straightforward correction and does not introduce any issues. The rest of the code seems to be well-structured and follows best practices. No further changes are required.
2. hamilton/function_modifiers/base.py:774
  • Draft comment:
    The function _resolve_nodes_error is simple and could be inlined where it is used to reduce unnecessary abstraction.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The function _resolve_nodes_error is simple and does not require a separate function. It could be inlined where it is used to reduce unnecessary abstraction.

Workflow ID: wflow_kOC85IcyqsUbyFOI


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@skrawcz skrawcz merged commit 0ae54e8 into DAGWorks-Inc:main Dec 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants