Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps version from 1.85.1 to 1.86.0 #1265

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

elijahbenizzy
Copy link
Collaborator

Version bump

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d670b4e in 10 seconds

More details
  • Looked at 25 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pyproject.toml:60
  • Draft comment:
    Ensure that the new 'furo' version is compatible with the rest of the dependencies and the project requirements, as it was previously pinned to a specific GitHub branch.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from a specific GitHub branch to a package version for 'furo' should be verified for compatibility.
2. pyproject.toml:60
  • Draft comment:
    Consider adding documentation under docs/ to explain the change in the furo dependency from a specific git commit to a versioned release. This will help users understand the change in dependency management.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR is a version bump, which is straightforward. However, the change in the pyproject.toml file regarding the furo dependency should be documented.

Workflow ID: wflow_VmSN7m6jmelduoLu


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 4e90daf in 2 seconds

More details
  • Looked at 7 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. hamilton/version.py:1
  • Draft comment:
    Version bump is correct and follows semantic versioning. No issues found.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version bump is correct and follows semantic versioning. No issues found.
2. hamilton/version.py:1
  • Draft comment:
    This version bump is appropriate and doesn't violate any of the specified rules. No changes are needed.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR is a simple version bump, which is appropriate and doesn't violate any of the specified rules. No changes are needed.

Workflow ID: wflow_zs49A39J6PHewktq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 7ec522a in 2 seconds

More details
  • Looked at 7 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. hamilton/version.py:1
  • Draft comment:
    Version bump is correct and aligns with the PR description. No issues found.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version bump is correct and aligns with the PR description. No issues found.
2. hamilton/version.py:1
  • Draft comment:
    No issues found with the version bump.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version bump is straightforward and doesn't violate any of the specified rules. No further comments are necessary.

Workflow ID: wflow_C50KWNE2jU1W1oWC


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@elijahbenizzy elijahbenizzy merged commit 415d85e into main Jan 3, 2025
0 of 5 checks passed
@elijahbenizzy elijahbenizzy deleted the version-bump-1.86.0 branch January 3, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant