Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious code #1266

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Remove spurious code #1266

merged 1 commit into from
Jan 4, 2025

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Jan 4, 2025

Changes

  • removes code committed by mistake

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz skrawcz requested a review from elijahbenizzy January 4, 2025 00:09
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9875acc in 22 seconds

More details
  • Looked at 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. hamilton/plugins/h_threadpool.py:4
  • Draft comment:
    The import statement for registry should be removed as it is no longer used in this file.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_rquznBqRKGc0y4SO


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@elijahbenizzy elijahbenizzy merged commit ac2140a into main Jan 4, 2025
24 checks passed
@elijahbenizzy elijahbenizzy deleted the remove_spurious_code branch January 4, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants