Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various minor bugs #130

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Fix various minor bugs #130

merged 3 commits into from
Apr 3, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

@elijahbenizzy elijahbenizzy commented Apr 3, 2023

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

We will likely need to rejigger this over time, but this is a quick way
to get support working. Note that we don't actually check the dictionary
type, but we're close enough.
@elijahbenizzy elijahbenizzy force-pushed the fix-various-minor-bugs branch from 0542cf3 to 89138ab Compare April 3, 2023 16:22
1. Index type in unit tests was incorrect
2. .mean() now does not filter non-numeric columns
3. pyspark appears not to be compatible with pandas 2.0
@elijahbenizzy elijahbenizzy force-pushed the fix-various-minor-bugs branch from 89138ab to c58fc90 Compare April 3, 2023 16:29
@elijahbenizzy elijahbenizzy marked this pull request as ready for review April 3, 2023 16:36
@elijahbenizzy elijahbenizzy requested a review from skrawcz April 3, 2023 16:37
@elijahbenizzy elijahbenizzy merged commit 8d0458a into main Apr 3, 2023
@elijahbenizzy elijahbenizzy deleted the fix-various-minor-bugs branch April 3, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants