Minor bug/usability fixes for 1.22.1
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that they can only be ParameterizedDependency (source or value).
elijahbenizzy
force-pushed
the
add-helpful-validate-message
branch
from
4ee94e3 to
7e446d5
Compare
elijahbenizzy
force-pushed
the
add-helpful-validate-message
branch
from
456757c to
4f23776
Compare
elijahbenizzy
force-pushed
the
add-helpful-validate-message
branch
from
4f23776 to
cb5385f
Compare
elijahbenizzy
changed the title
1.22.1
skrawcz
reviewed
Apr 14, 2023
| @@ -173,26 +200,10 @@ def __init__( | |||
| self.inputs = inputs if inputs is not None else {} | |||
| self.config = config if config is not None else {} | |||
| self.external_inputs = external_inputs if external_inputs is not None else [] | |||
| self._validate_config_inputs(self.config, self.inputs) | |||
| _validate_config_inputs(self.config, self.inputs) | |||
There was a problem hiding this comment.
Probably want a try catch here to then contextualize that it's a subdag decorator for node FOO?
There was a problem hiding this comment.
Yep good idea
skrawcz
approved these changes
Apr 14, 2023
elijahbenizzy
force-pushed
the
add-helpful-validate-message
branch
from
f76cd85 to
9dd521e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist