Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies logic for parameterized decorator #142

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

This has been a long time coming. Previously, we were looping through all the replacements and modifying the kwargs. Now, we just loop through all the expected inputs, and create their results from the kwargs or the literal values. In the case of "grouped", we do the same -- we just repeat some of the previous stuff. There's room for more simplification (breaking this out into a function), which could reduce the complexity of the code, but for now its OK.

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

This has been a long time coming. Previously, we were looping through
all the replacements and modifying the kwargs. Now, we just loop through
all the expected inputs, and create their results from the kwargs or the
literal values. In the case of "grouped", we do the same -- we just
repeat some of the previous stuff. There's room for more simplification
(breaking this out into a function), which could reduce the complexity
of the code, but for now its OK.
@elijahbenizzy elijahbenizzy requested a review from skrawcz April 18, 2023 20:58
@elijahbenizzy elijahbenizzy merged commit 907e886 into main Apr 20, 2023
@elijahbenizzy elijahbenizzy deleted the fix-parameterize-repeated-sources branch April 20, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants