Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config base #144

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Fix config base #144

merged 1 commit into from
Apr 23, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy
Fixes regression introduced by enforcing the config on the @config
a376075 
base decorator.

This decorator is almost never used -- its specifically built to have
arbitrary configuration elements passed through to a resolver function.
That said, some users found it, and it turns out it was hitting a
codepath that results in a null pointer. This changes the node
resolution code to bypass the prior checks we had to ensure that
all configuration elements were passed in, and handles the case in which
the passed configuration elements are null (as is with `@config` and no
other decorator)
@elijahbenizzy elijahbenizzy requested a review from skrawcz April 21, 2023 17:36
@elijahbenizzy elijahbenizzy mentioned this pull request Apr 21, 2023
Closed
@elijahbenizzy elijahbenizzy merged commit f0ea42a into main Apr 23, 2023
@elijahbenizzy elijahbenizzy deleted the fix-config-base branch April 23, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrawcz skrawcz skrawcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elijahbenizzy @skrawcz