Fixes dangling nodes in subdag with extract_* #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
force-pushed
the
subdag-dangling-nodes
branch
2 times, most recently
from
7e7114b to
3bdc29c
Compare
elijahbenizzy
changed the title
If there was a subdag that carried a dangling node (E.G. one that was not depended on by something within the subdag), and it was used by 'extract_fields', this would break. This occured because the extract_fields decorator did not know which node to extract fields from, as it looked for "final" nodes within the whole set of nodes produced by the function, including those within the subdag. This fix allow `@subdag` to modify it so we don't have this issue anymore. Currently, the way that the subdag indicates that its nodes are "non-final" (e.g. they can't be the target of extract_columns) is through a decorator. This can always be changed, but its not a bad way to do it. Furthermore, this will happen *after* the resolution of any subdags, ensuring that nesting subdags still works, as does any decorators within subdags.
elijahbenizzy
force-pushed
the
subdag-dangling-nodes
branch
from
3bdc29c to
f2169e4
Compare
skrawcz
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Meh using tags to talk between decorators feels ugly. OTOH, I'm not sure there's a better way, and its pretty clear what's happening...
Changes
How I tested this
Notes
Checklist