Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures that we can refer to another node from save_to/load_from #159

Merged
merged 2 commits into from
May 1, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

This fixes a bug in which input types were passed in as "Any", despite the fact that we knew the type from the dataclass. It would result in a mismatch, but now it works (as we use the type we know).

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

This fixes a bug in which input types were passed in as "Any", despite
the fact that we knew the type from the dataclass. It would result in a
mismatch, but now it works (as we use the type we know).
@@ -367,7 +367,7 @@ def test_loader_fails_for_missing_attribute():


def test_pandas_extensions_end_to_end(tmp_path_factory):
output_path = tmp_path_factory.mktemp("test_pandas_extensions_end_to_end") / "output.csv"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posix paths are fine, but I didn't want to change everything to have a union now, so casting is just as easy.

@elijahbenizzy elijahbenizzy requested a review from skrawcz May 1, 2023 21:29
@elijahbenizzy elijahbenizzy merged commit 3651a26 into main May 1, 2023
@elijahbenizzy elijahbenizzy deleted the input-str-save-to branch May 1, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants