Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds node name to hamilton dask DAG #163

Merged
merged 3 commits into from
May 17, 2023
Merged

Adds node name to hamilton dask DAG #163

merged 3 commits into from
May 17, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy elijahbenizzy mentioned this pull request May 4, 2023
Closed
skrawcz
skrawcz reviewed May 4, 2023
View reviewed changes
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind amending the commit to say "Fixes #161" so github links things and can close the issue when this merges?

@skrawcz skrawcz linked an issue May 4, 2023 that may be closed by this pull request
Dask task's displaying node names #161
Closed
@skrawcz
Fixes #161
dd42a1e 
So dask was taking the names of the wrapped function, rather than
the name of the actual node. So to keep things unique, we use the
recommended tokenize function to hash the inputs to create
a unique string. We use it for both name and dask_key_name because
our functions only depend on the input and aren't called multiple times.
So we should be good to reuse the same string value in both places.
skrawcz
skrawcz approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this up a bit.

@skrawcz skrawcz merged commit 901d5fa into main May 17, 2023
@skrawcz skrawcz deleted the dask-improvement branch May 17, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrawcz skrawcz skrawcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dask task's displaying node names
2 participants
@elijahbenizzy @skrawcz